Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Store pkey, sourceID and manualId when machine specs fails. #458

Merged
merged 2 commits into from
Jul 25, 2024
Merged

feat: Store pkey, sourceID and manualId when machine specs fails. #458

merged 2 commits into from
Jul 25, 2024

Conversation

YairHalberstadt
Copy link
Contributor

Fixes b/353893181

@YairHalberstadt
Copy link
Contributor Author

PTAL @shane-borden Thanks

shane-borden
shane-borden requested changes Jul 18, 2024
View reviewed changes
Copy link
Collaborator

@shane-borden shane-borden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The empty fields need to either also have double quotation marks or utilize the word NULL to represent an empty value. Preferably the empty double quote option is preferred.

@cofin cofin changed the title Store pkey, sourceID and manualId when machine specs fails. feat: Store pkey, sourceID and manualId when machine specs fails. Jul 18, 2024
@YairHalberstadt
Copy link
Contributor Author

The empty fields need to either also have double quotation marks or utilize the word NULL to represent an empty value. Preferably the empty double quote option is preferred.

Done

@YairHalberstadt
Store pkey, sourceID and manualId when machine specs fails.
c4e6aa4 
Fixes b/353893181

Signed-off-by: Yair Halberstadt <yairh@google.com>
@YairHalberstadt
Update db-machine-specs.sh
9d21d02
shane-borden
shane-borden approved these changes Jul 25, 2024
View reviewed changes
Copy link
Collaborator

@shane-borden shane-borden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shane-borden shane-borden merged commit b2ed09a into GoogleCloudPlatform:main Jul 25, 2024
9 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shane-borden shane-borden shane-borden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YairHalberstadt @shane-borden