fix(cli): Readiness check fixes and grouping the per DB checks #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cofin
reviewed
Oct 28, 2024
cofin
reviewed
Oct 28, 2024
cofin
reviewed
Oct 28, 2024
cofin
reviewed
Oct 28, 2024
cofin
reviewed
Oct 28, 2024
cofin
reviewed
Oct 28, 2024
cofin
reviewed
Oct 28, 2024
cofin
reviewed
Oct 28, 2024
cofin
previously approved these changes
Oct 28, 2024
Also fixed some minor bugs.
cofin
force-pushed
the
readiness_check_fixes
branch
from
e8d1fc4 to
85d1379
Compare
Signed-off-by: Cody Fincher <204685+cofin@users.noreply.github.com>
Signed-off-by: Cody Fincher <204685+cofin@users.noreply.github.com>
cofin
changed the title
Signed-off-by: Cody Fincher <204685+cofin@users.noreply.github.com>
Signed-off-by: Cody Fincher <204685+cofin@users.noreply.github.com>
Signed-off-by: Cody Fincher <204685+cofin@users.noreply.github.com>
Signed-off-by: Cody Fincher <204685+cofin@users.noreply.github.com>
Signed-off-by: Cody Fincher <204685+cofin@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a few issues found during my testing.
Also grouped the per DB check results to concise the results table.