-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve test_alternatives.sh script #627
Improve test_alternatives.sh script #627
Conversation
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
1 similar comment
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
…ints, and not requiring the user to login if the credentials already exist Author: Paul Moon <paulmoon@users.noreply.github.com>
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Author: Paul Moon <paulmoon@users.noreply.github.com>
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Improvements:
cp -R alternatives/krm
should becp -R alternatives/krm/
, and same for TerraformPubSubSubscription
d1
todeployment
to be slightly more descriptiveIf this PR looks good, I'll make similar changes to the other existing
test_alternatives.sh
script. This should make futuretest_alternatives.sh
script better.