-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Spanner samples for MR CMEK #2772
base: main
Are you sure you want to change the base?
Conversation
Here is the summary of changes. You are about to add 4 region tags.
This comment is generated by snippet-bot.
|
Change KmsKeyName to KmsKeyNames
Change KmsKeyNamesAsCryptoKeyName to KmsKeyNamesAsCryptoKeyNames
Change KmsKeyNamesAsCryptoKeyName to be KmsKeyNamesAsCryptoKeyNames
Change KmsKeyNamesAsCryptoKeyName to be KmsKeyNamesAsCryptoKeyNames
Change KmsKeyNamesAsCryptoKeyName to be KmsKeyNamesAsCryptoKeyNames and use database encryption config to print
Use database encryption config to print
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issues I've commented on appear on several places even though I flag them on a single place, please fix all ocurrences.
This code doesn't build, see the build log for errors.
When you have run the tests locally and they pass, let me know and I can run them on the PR with the backup tests enabled to make certain they run on CI before merging. At the moment these new tests will conflict with the existing backup samples and tests.
spanner/api/Spanner.Samples.Tests/CreateBackupWithMRCMEKAsyncTest.cs
Outdated
Show resolved
Hide resolved
spanner/api/Spanner.Samples.Tests/CreateBackupWithMRCMEKAsyncTest.cs
Outdated
Show resolved
Hide resolved
spanner/api/Spanner.Samples.Tests/CreateDatabaseWithMRCMEKAsyncTest.cs
Outdated
Show resolved
Hide resolved
…Test.cs Change naming from MRCMEK to MrCmek
…ithMrCmekAsyncTest.cs Change naming from MRCMEK to MrCmek
…aseWithMrCmekAsyncTest.cs Change from MRCMEK to MrCmek
…abaseWithMrCmekAsyncTest.cs Change from MRCMEK to MrCmek
Change from MRCMEK to MrCmek
…rCmekAsync.cs Change from MRCMEK to MrCmek
…ithMrCmekAsync.cs Change from MRCMEK to MrCmek
…eWithMrCmekAsync.cs Change from MRCMEK to MrCmek
Update copyright
Update copyright
Update copyright
Update copyright
Update copyright
Update copyright
Update copyright
Update copyright
Use MrCmekBackupId
Use FixedMrCmekDatabaseId and MrCmekBackupId
Use MrCmekDatabaseId
Use MrCmekRestoreDatabaseId and FixedMrCmekBackupId. Use KmsKeyNames instead of KmsKeyName
Use default poll settings
Change log
Change log
Remove old log
Change log
Change logs
Assert keys match
Change assert
Change assert
Remove old assert
Change assert
Fix naming
Add samples and tests for create database, create backup, copy backup, and restore backup.