ci: e2e deployment integration test #109
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* squashed commit from forked testing environment. Cloud Build e2e test runs successfully, but some LINT and cleanup issues still to address. ---------
eeaton
changed the title
… usually works, but last run did have a flaky error about waiting for instance primary state
…ner, use that container image for each step of e2e test, remove extra steps to download gcloud library within the terraform-google-gcloud module, fix the debug disabling of tf dependencies in pre_tf_setup
eeaton
force-pushed
the
squashed-e2e-int-testing
branch
from
706df97
to
1bb6d28
Compare
…ot not available on older version.
…ected to run as a highly privileged account, so disable scanning the image and hitting issues with CKV_DOCKER_3
…mail, and ensure it is used consistently across modules
1: "yes | gcloud auth" has some different behavior across Cloud Shell vs local terminal, so it's safer to prompt the user and get a consistent result. 2: update logic to not change ADC if a service account is already in use, but give a warning to set ADC separately
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable e2e integration testing.
This creates a test in Cloud Build that must pass the following before a PR can merge to a major version branch:
This does not yet add functional tests for the outcomes of specific processors, but the terratest framework enables us to add those tests in future PRs.
Note on Cloud Build config outside of this repo: I will configure the Cloud Build GitHub app to target only specific test branches in this repo, so as to not interrupt other PR merging to
rc1.3.Once this is ready to merge to
rc1.3, I will update the Cloud Build config to also targetrc1.3.We'll also need to evaluate in the future whether/when to extend the checks to main and other version branches (today, main and versions 1.2 / 1.1 aren't automatable)