Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable Ubsan in CI #462

Closed
nareddyt opened this issue Jan 14, 2021 · 0 comments · Fixed by #755
Closed

Re-enable Ubsan in CI #462

nareddyt opened this issue Jan 14, 2021 · 0 comments · Fixed by #755
Assignees
@nareddyt

Comments

@nareddyt
Copy link
Contributor

When updating envoy in #445, the Undefined behavior CI build keeps failing with:

ld.lld-10: error: undefined symbol: __muloti4
>>> referenced by int128_have_intrinsic.inc:251 (external/com_google_absl/absl/numeric/int128_have_intrinsic.inc:251)
>>>               bazel-out/k8-dbg/bin/external/com_google_absl/absl/strings/_objs/strings/numbers.pic.o:(absl::operator*(absl::int128, absl::int128))

This looks like a common bug mentioned in envoyproxy/envoy#13973. I spent some time investigating but I cannot find a good solution.

Let's disable Ubsan for now to unblock development. Nighthawk also followed the same approach - envoyproxy/nighthawk#593
@nareddyt nareddyt self-assigned this Jan 14, 2021
This was referenced Jan 14, 2021
Merged
Closed
nareddyt added a commit that referenced this issue Jan 14, 2021
@nareddyt
Update Envoy to v1.17.0 (#445)
f0fbb62 
Due to a bug in clang, I had to disable UbSan builds. See #462 for more context. We can work with Nighthawk to find a good solution.

`ESPv2-API-regression-test` test failure is incorrect, there is no API change. We updated the bazel version and some bazel flags changed. Because the test checks out an older commit, the build with old bazel flags fails.

Signed-off-by: Teju Nareddy <nareddyt@google.com>
@nareddyt nareddyt mentioned this issue Nov 29, 2022
Merged
nareddyt added a commit that referenced this issue Nov 29, 2022
@nareddyt
Update to Envoy 1.24.0 (#755)
c865900 
Closes #462

Signed-off-by: Teju Nareddy <nareddyt@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nareddyt nareddyt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update to Envoy 1.24.0 nareddyt/esp-v2
1 participant
@nareddyt