feat: endpoint to post xunit test data #254
Conversation
| @@ -96,7 +101,7 @@ class PostBuildHandler { | |||
| if (typeof x.ok !== 'boolean' || !x.id || !x.name) { | |||
| throw new InvalidParameterError('Missing All Test Case Info'); | |||
| } | |||
| const testcase = new TestCaseRun(x.ok ? 'ok' : 'not ok', x.id, x.name); | |||
| const testcase = new TestCaseRun(x.ok ? 'ok' : 'not ok', x.name); | |||
There was a problem hiding this comment.
You seem to be using "ok" and "not ok" strings in multiple places -- might be helpful to save them as constants and reuse the constant
There was a problem hiding this comment.
I think this is actually a quirk of parsing tap files, I don't think I can change it.
There was a problem hiding this comment.
I'm okay with leaving this for now ... I find the fact that we create a string ok, not ok weird, as it's immediately turned into a boolean when we store it, but we already had this behavior.
tldr; seems like logic worth cleaning up.
There was a problem hiding this comment.
I did actually go through and start to clean it up, but that constructor is called in a number of different places and it was getting a bit messy. I'll make an issue for this to be addressed at some point, though.
| let log = (failure === undefined) ? error._text : failure._text; | ||
| // Java puts its test logs in a CDATA element. | ||
| if (log === undefined) { | ||
| log = failure._cdata; |
There was a problem hiding this comment.
Need to update this to also get error._cdata. See googleapis/repo-automation-bots#873, which simplifies the error vs failure logic a bit.
There was a problem hiding this comment.
Oh okay, thank you! Added this to my new draft PR: #259
|
|
||
| // endpoint expects the the required buildinfo to be in req.body.metadata to already exist and be properly formatted. | ||
| // required keys in the req.body.metadata are the inputs for addBuild in src/add-build.js | ||
| this.app.post('/api/build/xml', async (req, res, next) => { |
There was a problem hiding this comment.
How do we get which repo or build this XML is for?
There was a problem hiding this comment.
That will be sent in the metadata. I wrote a rough draft of how the data will be sent, if we do use buildcop: https://github.com/cedpeters/repo-automation-bots/pull/1/files
No description provided.