Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove obsolete blank prints #144

Merged
merged 2 commits into from
Aug 5, 2022

Conversation

anniefu
Copy link
Contributor

@anniefu anniefu commented Aug 5, 2022

These blank lines were included to force-flush logs on previous versions of GCF, but are no longer needed because there have been changes to GCF log handling since then.

@anniefu anniefu requested review from jihuin and kappratiksha August 5, 2022 21:13
funcframework/framework.go Outdated Show resolved Hide resolved
@anniefu anniefu merged commit 5c7091f into GoogleCloudPlatform:master Aug 5, 2022
anniefu added a commit to anniefu/functions-framework-go that referenced this pull request Aug 23, 2022
anniefu added a commit to anniefu/functions-framework-go that referenced this pull request Aug 23, 2022
anniefu added a commit to anniefu/functions-framework-go that referenced this pull request Aug 23, 2022
anniefu added a commit that referenced this pull request Aug 23, 2022
* Revert "fix: remove obsolete blank prints (#144)"

This reverts commit 5c7091f.`:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants