Fix: Added logic to mount Linux boot disk with LVM and to mount NTFS disks automatically #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @vinay-vgs, Could you pls adjust you PR to adhere the standards described at CONTRIBUTING? |
vinay-vgs
changed the title
halleysouza
reviewed
Mar 20, 2024
There was a problem hiding this comment.
Hey @vinay-vgs thanks for your PR. I am adding some notes, let me know wdyt.
| fs=$(lsblk -rf /dev/disk/by-id/google-${disk} | egrep -i 'ext[3-4]|xfs|ntfs'| awk '{print $2}') | ||
| case $fs in | ||
| ntfs) | ||
| apt-get install -y ntfs-3g |
There was a problem hiding this comment.
I dont think we can assume the VM will have access to the internet. Better to have validation of internet access or we'll risk to delay the boot for too long
| disk_map=$(lsblk -rf /dev/disk/by-id/google-${disk}| egrep -i LVM2_member| awk '{print $1}') | ||
| if [[ -n ${disk_map} ]]; | ||
| then | ||
| apt-get install -y lvm2 |
| if [[ -n ${disk_map} ]]; | ||
| then | ||
| apt-get install -y lvm2 | ||
| pvscan; vgscan |
There was a problem hiding this comment.
I think we can replace the lines 26, 28 and 29 with only "pvscan -ay" and save some bytes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
..