Storage: updating Connection docstring; turning make_request private. #604
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making it clear in the docstring that the Connection itself only handles
storage.bucket...
API methods and that the other classes handle the other 30 (give or take) methods of the API.@tseaver This documents our decision from earlier today (about the responsibilities of
Connection
).Also note
storage.buckets.update
anywhere (butConnection.api_request
would allow it)storage.buckets.patch
onConnection
. Only viaBucket
(through_PropertyMixin._patch_properties()
).Bucket._reload_properties()
(via_PropertyMixin
) andConnection.get_bucket
implementstorage.buckets.get
.For your reference: discovery document.