You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
dhermes
changed the title
Implict set_ methods should return the values set and raise if not successful
Implicit set_ methods should return the values set and raise if not successful
Feb 13, 2015
datastore._implicit_environ.set_default_dataset_id throws an exception if not set but does not return
datastore._implicit_environ.set_default_connection neither throws nor returns
datastore.__init__.set_defaults just wraps set_default_dataset_id and set_default_connection, so could get exception throwing for free but returning is not simple. We could just remove this since we have the lazy loading now.
storage.__init__.set_default_bucket neither returns nor throws
storage.__init__.set_default_project neither returns nor throws
storage.__init__.set_default_connection neither returns nor throws
storage.__init__.set_default_defaults neither returns nor throws
See @tseaver comment about returning (and the current storage regression test hacky behavior).
This will likely require doing something like
The text was updated successfully, but these errors were encountered: