remove 0 value constraint from backup-file-count

GoogleCloudPlatform · Nov 24, 2023 · 73574b3 · 73574b3
1 parent 90d1dc7
commit 73574b3
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/internal/config/yaml_parser.go b/internal/config/yaml_parser.go
@@ -55,8 +55,8 @@ func IsValidLogRotateConfig(config LogRotateConfig) error {
 	if config.MaxFileSizeMB <= 0 {
 		return fmt.Errorf("max-file-size-mb should be atleast 1")
 	}
-	if config.BackupFileCount <= 0 {
-		return fmt.Errorf("backup-file-count should be atleast 1")
+	if config.BackupFileCount < 0 {
+		return fmt.Errorf("backup-file-count should be 0 (to retain all backup files) or a positive value")
 	}
 	return nil
 }

diff --git a/internal/config/yaml_parser_test.go b/internal/config/yaml_parser_test.go
@@ -111,5 +111,5 @@ func (t *YamlParserTest) TestReadConfigFile_InvalidLogRotateConfig2() {
 
 	AssertNe(nil, err)
 	AssertTrue(strings.Contains(err.Error(),
-		fmt.Sprintf(parseConfigFileErrMsgFormat, "backup-file-count should be atleast 1")))
+		fmt.Sprintf(parseConfigFileErrMsgFormat, "backup-file-count should be 0 (to retain all backup files) or a positive value")))
 }