address self-review comments

GoogleCloudPlatform · Aug 8, 2024 · 96116f1 · 96116f1
1 parent 3f422ed
commit 96116f1
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/...trics/scripts/testing_on_gke/examples/dlio/unet3d-loading-test/templates/dlio-tester.yaml b/...trics/scripts/testing_on_gke/examples/dlio/unet3d-loading-test/templates/dlio-tester.yaml
@@ -86,6 +86,7 @@ spec:
  ++workload.reader.read_threads={{ .Values.dlio.readThreads }} \
  ++workload.output.folder=/logs/{{ .Values.dlio.numFilesTrain }}-{{ .Values.dlio.recordLength }}-{{ .Values.dlio.batchSize }}/{{ .Values.scenario }}
 
+ # dump the gcsfuse-mount-configuration to a file in output-directory.
  {{ if eq .Values.scenario "gcsfuse-generic"}}
  echo "{{ .Values.gcsfuse.mountOptions }}" > /logs/{{ .Values.dlio.numFilesTrain }}-{{ .Values.dlio.recordLength }}-{{ .Values.dlio.batchSize }}/{{ .Values.scenario }}/gcsfuse_mount_options
  {{ end }}

diff --git a/perfmetrics/scripts/testing_on_gke/examples/fio/loading-test/templates/fio-tester.yaml b/perfmetrics/scripts/testing_on_gke/examples/fio/loading-test/templates/fio-tester.yaml
@@ -127,6 +127,7 @@ spec:
  echo "Run fio tests..."
  mkdir -p /data/fio-output/{{ .Values.scenario }}/$read_type
 
+ # dump the gcsfuse-mount-configuration to a file in output-directory.
  {{ if eq .Values.scenario "gcsfuse-generic" }}
  echo "{{ .Values.gcsfuse.mountOptions }}" > /data/fio-output/{{ .Values.scenario }}/$read_type/gcsfuse_mount_options
  {{ end }}
@@ -174,7 +175,7 @@ spec:
  driver: gcsfuse.csi.storage.gke.io
  volumeAttributes:
  bucketName: {{ .Values.bucketName }}
- # gcsfuseLoggingSeverity: "info"
+ gcsfuseLoggingSeverity: "info"
  mountOptions: "{{ .Values.gcsfuse.mountOptions }}"
  {{- else if eq .Values.scenario "gcsfuse-file-cache" }}
  csi: