-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing all the logs which is used under --debug_fs flag #1074
Removing all the logs which is used under --debug_fs flag #1074
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In future, if we need anything to log in file-system. We can use the same flag --debug_fuse.
if we want to log anything in gcsfuse, how to log it?
[Prince] As per my understanding, gcsfuse is working right now as a thin connector b/w fuse and gcs. So, most of the logs will be part of these two flags. In some parts of GCSFuse, E.g. ContentCache, logs are written with the default logger, not guarded by any special debug flag. And most of the logs (E.g. auth, stackdriver) in gcsfuse are one time setup log, which are also written with the default logger.
So, I don't think we need another flag to guard gcsfuse related logs unless until we are introduce a complex feature related to caching or some optimisations.
Description
Removing the logs which was used under
--debug_fs
flag. Keeping the flag for the future, in case we want to log in gcsfuse code.Why?
--debug_fs
was subset of logging via--debug_fuse
. So, we can use--debug_fuse
flag while logging.Link to the issue in case of a bug fix.
Testing details
debug_fs
flag is not working any more.