Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing all the logs which is used under --debug_fs flag #1074

Merged
merged 7 commits into from
Apr 27, 2023

Conversation

raj-prince
Copy link
Collaborator

@raj-prince raj-prince commented Apr 25, 2023

Description

Removing the logs which was used under --debug_fs flag. Keeping the flag for the future, in case we want to log in gcsfuse code.

Why?

  • Logging via --debug_fs was subset of logging via --debug_fuse. So, we can use --debug_fuse flag while logging.
  • At FS level gcsfuse only converts from syscall (fuse) to GCS api call.

Link to the issue in case of a bug fix.

Testing details

  1. Manual -
  • debug_fs flag is not working any more.
  • Mouted with other remaining flags, logging is working fine.
  1. Unit tests - automation.
  2. Integration tests - automation.

@raj-prince raj-prince requested review from vadlakondaswetha, sethiay and Tulsishah and removed request for sethiay April 25, 2023 16:05
@raj-prince raj-prince self-assigned this Apr 25, 2023
Copy link
Collaborator

@vadlakondaswetha vadlakondaswetha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In future, if we need anything to log in file-system. We can use the same flag --debug_fuse.

if we want to log anything in gcsfuse, how to log it?

[Prince] As per my understanding, gcsfuse is working right now as a thin connector b/w fuse and gcs. So, most of the logs will be part of these two flags. In some parts of GCSFuse, E.g. ContentCache, logs are written with the default logger, not guarded by any special debug flag. And most of the logs (E.g. auth, stackdriver) in gcsfuse are one time setup log, which are also written with the default logger.
So, I don't think we need another flag to guard gcsfuse related logs unless until we are introduce a complex feature related to caching or some optimisations.

Tulsishah

This comment was marked as resolved.

@raj-prince raj-prince requested a review from Tulsishah April 26, 2023 10:00
@raj-prince raj-prince changed the title Removing --debug_fs flags Removing all the logs which is used under --debug_fs flag Apr 26, 2023
flags.go Show resolved Hide resolved
flags.go Show resolved Hide resolved
@raj-prince raj-prince requested a review from sethiay April 27, 2023 04:48
@raj-prince raj-prince merged commit 8ae6c3e into GoogleCloudPlatform:master Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants