-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run readonly tests with mount dir option #1086
Merged
Tulsishah
merged 24 commits into
GoogleCloudPlatform:master
from
Tulsishah:run_readonly_tests_with_mount_dir_option
May 4, 2023
Merged
Run readonly tests with mount dir option #1086
Tulsishah
merged 24 commits into
GoogleCloudPlatform:master
from
Tulsishah:run_readonly_tests_with_mount_dir_option
May 4, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be pull request template
Description
Currently, Readonly integration tests are running only for the testbucket flag. I made changes so that for read-only tests, when we pass the mountedDiectory flag, we need to pass the testBucket flag with the mounted bucket, and it will run the tests with the mountedDiectory flag.
Link to the issue in case of a bug fix.
Testing details
Manual -
From gcsfuse directory with testBucket flag
GODEBUG=asyncpreemptoff=1 go test ./tools/integration_tests/... -p 1 --integrationTest -v --testbucket=myBucket
Results
All the tests are passing
From cd tool/integration_tests/readonly
GODEBUG=asyncpreemptoff=1 go test . -p 1 --integrationTest -v --mountedDirectory=/usr/local/google/home/tulsishah/gcs
Results
2023/05/04 09:17:24 Please pass testBucket mounted in mountedDirectory.
FAIL github.com/googlecloudplatform/gcsfuse/tools/integration_tests/readonly 0.006s
FAIL
From cd tool/integration_tests/readonly
GODEBUG=asyncpreemptoff=1 go test . -p 1 --integrationTest -v --mountedDirectory=/usr/local/google/home/tulsishah/gcs --testbucket=tulsishah_test
mountedDirectory mounted for tulsishah_test with --o=ro flag
Results
All the tests are working fine
From cd tool/integration_tests/implicitdir
GODEBUG=asyncpreemptoff=1 go test . -p 1 --integrationTest -v --mountedDirectory=/usr/local/google/home/tulsishah/gcs
Results
All the tests are working fine
From cd tool/integration_tests/implicitdir
GODEBUG=asyncpreemptoff=1 go test . -p 1 --integrationTest -v --mountedDirectory=/usr/local/google/home/tulsishah/gcs --testbucket=tulsishah_test
Results
2023/05/04 09:18:15 Both --testbucket and --mountedDirectory can't be specified at the same time.
FAIL github.com/googlecloudplatform/gcsfuse/tools/integration_tests/implicitdir 0.007s
FAIL
Unit tests - N/A
Integration tests - All the integration tests are working fine.