Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TestInstalledPackage flag to integration testing. #1150

Merged
merged 6 commits into from
Jun 1, 2023
Merged

Add TestInstalledPackage flag to integration testing. #1150

merged 6 commits into from
Jun 1, 2023

Conversation

ashmeenkaur
Copy link
Collaborator

@ashmeenkaur ashmeenkaur commented May 30, 2023 •
edited
Loading

Description

Added flag:

  • testInstalledPackage: [optional flag] [default value false], when set, this flag assumes that gcsfuse is already installed on the host machine and runs test against the pre-installed gcsfuse.

Changes are made so that integration tests skip building the local binary for testing.

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - Manually tested on a VM.
  • All the tests pass with --test-bucket flag.
  • With --mountedDirectory flag:
    • mounting tests pass
    • operations tests pass
    • readonly tests passes when both test-bucket and --mountedDirectory flag are set.
    • rename_dir_limit tests pass
  1. Unit tests - NA
  2. Integration tests - Test scripts for CD pipeline are in progress.

@ashmeenkaur ashmeenkaur changed the title CL to add TestPackageDir and TestPackageVer flag for integration testing. Add TestPackageDir and TestPackageVer flag for integration testing. May 30, 2023
@ashmeenkaur ashmeenkaur changed the title Add TestPackageDir and TestPackageVer flag for integration testing. Add TestPackagePath flag for integration testing. May 30, 2023
@ashmeenkaur ashmeenkaur changed the title Add TestPackagePath flag for integration testing. Add TestInstalledPackage flag for integration testing. May 30, 2023
@ashmeenkaur ashmeenkaur changed the title Add TestInstalledPackage flag for integration testing. Add TestInstalledPackage flag to integration testing. May 30, 2023
Tulsishah
Tulsishah reviewed May 30, 2023
View reviewed changes
Copy link
Collaborator

@Tulsishah Tulsishah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please mention that all the integration tests are working fine with both the flags.

tools/integration_tests/util/mounting/mounting.go Outdated Show resolved Hide resolved
tools/integration_tests/util/setup/setup.go Outdated Show resolved Hide resolved
tools/integration_tests/mounting/mount_helper_test.go Outdated Show resolved Hide resolved
tools/integration_tests/mounting/mount_helper_test.go Outdated Show resolved Hide resolved
tools/integration_tests/mounting/mount_helper_test.go Outdated Show resolved Hide resolved
@ashmeenkaur ashmeenkaur force-pushed the integration-test-flag branch 2 times, most recently from 8ee24ed to ebd6cd7 Compare June 1, 2023 06:41
@ashmeenkaur ashmeenkaur force-pushed the integration-test-flag branch 2 times, most recently from 74ab729 to e9d114f Compare June 1, 2023 08:04
sethiay
sethiay approved these changes Jun 1, 2023
View reviewed changes
tools/integration_tests/mounting/main_test.go Outdated Show resolved Hide resolved
@ashmeenkaur ashmeenkaur merged commit 5cd3ae9 into master Jun 1, 2023
@ashmeenkaur ashmeenkaur deleted the integration-test-flag branch August 30, 2023 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tulsishah Tulsishah Tulsishah approved these changes

@sethiay sethiay sethiay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ashmeenkaur @sethiay @Tulsishah