Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update install test.sh with public documentation install commands #1496

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

ashmeenkaur
Copy link
Collaborator

@ashmeenkaur ashmeenkaur commented Nov 8, 2023

Description

Update install_test.sh with the install commands mentioned here.

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - Manually ran the script on all OS types and verified that it is working as intended.
  2. Unit tests - NA
  3. Integration tests - NA

Copy link
Collaborator

@Tulsishah Tulsishah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good to me. I believe you have tested on louhi pipeline

@ashmeenkaur
Copy link
Collaborator Author

Changes looks good to me. I believe you have tested on louhi pipeline

Yes, I've tested on louhi pipeline.

@ashmeenkaur ashmeenkaur marked this pull request as ready for review November 9, 2023 06:48
gpgkey=https://packages.cloud.google.com/yum/doc/yum-key.gpg
https://packages.cloud.google.com/yum/doc/rpm-package-key.gpg
https://packages.cloud.google.com/yum/doc/rpm-package-key.gpg
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: remove extra space.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copy pasted the install command from https://cloud.google.com/storage/docs/gcsfuse-install because of which this extra space crept in. 😅 Going ahead with the merge.

@ashmeenkaur ashmeenkaur merged commit dc6aeca into dec_2023_release Nov 9, 2023
8 checks passed
@ashmeenkaur ashmeenkaur deleted the update_install_test.sh branch November 10, 2023 10:56
gargnitingoogle pushed a commit that referenced this pull request Nov 28, 2023
gargnitingoogle pushed a commit that referenced this pull request Nov 28, 2023
gargnitingoogle pushed a commit that referenced this pull request Nov 28, 2023
gargnitingoogle pushed a commit that referenced this pull request Nov 29, 2023
raj-prince pushed a commit that referenced this pull request Nov 29, 2023
gargnitingoogle pushed a commit that referenced this pull request Jan 4, 2024
ashmeenkaur added a commit that referenced this pull request Jan 9, 2024
ashmeenkaur added a commit that referenced this pull request Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants