Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moving from gsutil to gcloud in e2e tests #1852

Merged
merged 17 commits into from
Apr 26, 2024

Conversation

Tulsishah
Copy link
Collaborator

@Tulsishah Tulsishah commented Apr 19, 2024

Description

Moving from gsutil to gcloud in e2e tests as gsutil will anyways getting deprecated and in TPC environment gsutil is not supported.

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - Louhi pipeline on all the VMs
  2. Unit tests - NA
  3. Integration tests - Automated

@Tulsishah Tulsishah added the execute-integration-tests Run only integration tests label Apr 19, 2024
@Tulsishah Tulsishah force-pushed the shift_from_gsutil_to_gcloud_in_e2e_tests branch 2 times, most recently from 5b306dd to 14a84e4 Compare April 23, 2024 14:07
@Tulsishah Tulsishah marked this pull request as ready for review April 24, 2024 03:39
@Tulsishah Tulsishah requested review from ashmeenkaur and a team as code owners April 24, 2024 03:39
@Tulsishah Tulsishah force-pushed the shift_from_gsutil_to_gcloud_in_e2e_tests branch from 14a84e4 to dcce45b Compare April 24, 2024 11:48
@ashmeenkaur ashmeenkaur requested review from raj-prince and removed request for raj-prince April 25, 2024 08:18
ashmeenkaur
ashmeenkaur previously approved these changes Apr 26, 2024
Copy link
Collaborator

@ashmeenkaur ashmeenkaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 nit comments, LGTM otherwise :)

Co-authored-by: Ashmeen Kaur <57195160+ashmeenkaur@users.noreply.github.com>
@Tulsishah Tulsishah merged commit c2f83f7 into master Apr 26, 2024
8 checks passed
@Tulsishah Tulsishah deleted the shift_from_gsutil_to_gcloud_in_e2e_tests branch July 19, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
execute-integration-tests Run only integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants