-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initializing new storage control client #1865
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tulsishah
force-pushed
the
storage_control_client
branch
from
April 26, 2024 05:29
f3ec08e
to
ed62e4c
Compare
Tulsishah
changed the title
Storage control client
Initializing new storage control client incase of GRPC protocol.
Apr 26, 2024
Tulsishah
changed the title
Initializing new storage control client incase of GRPC protocol.
Initializing new storage control client incase of GRPC protocol
Apr 26, 2024
Tulsishah
changed the title
Initializing new storage control client incase of GRPC protocol
Initializing new storage control client
Apr 29, 2024
Tulsishah
force-pushed
the
storage_control_client
branch
from
April 29, 2024 10:05
e10d39d
to
db3245c
Compare
Tulsishah
force-pushed
the
storage_control_client
branch
from
April 29, 2024 10:14
db3245c
to
60268ab
Compare
ankitaluthra1
requested changes
Apr 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NA
Tulsishah
force-pushed
the
storage_control_client
branch
from
May 1, 2024 07:40
8d59a23
to
78d6313
Compare
Tulsishah
commented
May 3, 2024
tritone
reviewed
May 3, 2024
ankitaluthra1
requested changes
May 6, 2024
ankitaluthra1
previously approved these changes
May 8, 2024
raj-prince
reviewed
May 8, 2024
raj-prince
reviewed
May 8, 2024
raj-prince
reviewed
May 8, 2024
raj-prince
approved these changes
May 8, 2024
Tulsishah
added
hns-integration
Representative-PR
and removed
execute-integration-tests
Run only integration tests
tulsishah
labels
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the enable-hns flag is turned on, a new storage control client is initialized for GRPC protocol connections to utilize the new control client APIs. Retry logic, similar to that used for the storage client, has been added.
Link to the issue in case of a bug fix.
NA
Testing details