Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overriding authConfig flag #1878

Merged
merged 18 commits into from
May 2, 2024
Merged

Overriding authConfig flag #1878

merged 18 commits into from
May 2, 2024

Conversation

Tulsishah
Copy link
Collaborator

@Tulsishah Tulsishah commented May 1, 2024 •
edited
Loading

Description

  • Overriding authConfig:AnonymousAccess config file flag with cli flag.
  • The priority is given to the cli flag if both are set. The default value of the flag and config is false.

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - Manually varified.
  2. Unit tests - Added
  3. Integration tests - Automated.

@Tulsishah Tulsishah added the execute-integration-tests Run only integration tests label May 1, 2024
@Tulsishah Tulsishah marked this pull request as ready for review May 2, 2024 06:38
@Tulsishah Tulsishah requested a review from a team as a code owner May 2, 2024 06:38
@Tulsishah Tulsishah requested review from sethiay and raj-prince May 2, 2024 06:38
@Tulsishah Tulsishah merged commit f2c3405 into master May 2, 2024
8 checks passed
@Tulsishah Tulsishah deleted the overriding_auth_flagg branch July 19, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raj-prince raj-prince raj-prince approved these changes

@sethiay sethiay Awaiting requested review from sethiay sethiay is a code owner automatically assigned from GoogleCloudPlatform/gcsfuse-codeowners

Assignees
No one assigned
Labels
execute-integration-tests Run only integration tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tulsishah @raj-prince