Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parallel downloads job #2005

Merged
merged 9 commits into from
Jun 18, 2024
Merged

Add parallel downloads job #2005

merged 9 commits into from
Jun 18, 2024

Conversation

sethiay
Copy link
Collaborator

@sethiay sethiay commented Jun 12, 2024

Description

Add parallel downloads job

Note: I will add more unit/composite tests in the next PR. Also, I will enable the configs to run e2e tests with parallel downloads in a separate PR.

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - NA
  2. Unit tests - NA
  3. Integration tests - NA

@sethiay sethiay added the execute-integration-tests Run only integration tests label Jun 12, 2024
Copy link

codecov bot commented Jun 12, 2024

Codecov Report

Attention: Patch coverage is 90.15152% with 13 lines in your changes missing coverage. Please review.

Project coverage is 71.50%. Comparing base (b6eca68) to head (7d92738).

Files Patch % Lines
internal/cache/file/downloader/job.go 89.65% 7 Missing and 2 partials ⚠️
...al/cache/file/downloader/parallel_downloads_job.go 91.11% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2005      +/-   ##
==========================================
+ Coverage   71.40%   71.50%   +0.10%     
==========================================
  Files          97       98       +1     
  Lines       10708    10740      +32     
==========================================
+ Hits         7646     7680      +34     
+ Misses       2719     2717       -2     
  Partials      343      343              
Flag Coverage Δ
unittests 71.50% <90.15%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sethiay sethiay marked this pull request as ready for review June 12, 2024 10:07
@sethiay sethiay requested a review from a team as a code owner June 12, 2024 10:07
Copy link
Collaborator

@raj-prince raj-prince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor comments.

Copy link
Collaborator

@vadlakondaswetha vadlakondaswetha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will rely on Prince review for unit tests

internal/cache/file/downloader/job.go Show resolved Hide resolved
internal/cache/file/downloader/job.go Show resolved Hide resolved
internal/cache/file/downloader/job.go Show resolved Hide resolved
internal/cache/file/downloader/job.go Show resolved Hide resolved
Copy link
Collaborator

@raj-prince raj-prince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few nits.

LGTM, assuming we are adding unit tests for newly added method as separate PR.

@sethiay sethiay requested a review from raj-prince June 17, 2024 15:08
@sethiay sethiay merged commit 76edba7 into master Jun 18, 2024
15 checks passed
@sethiay sethiay added the parallel-downloads Tag to track PRs related to parallel downloads project label Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
execute-integration-tests Run only integration tests parallel-downloads Tag to track PRs related to parallel downloads project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants