-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add parallel downloads job #2005
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2005 +/- ##
==========================================
+ Coverage 71.40% 71.50% +0.10%
==========================================
Files 97 98 +1
Lines 10708 10740 +32
==========================================
+ Hits 7646 7680 +34
+ Misses 2719 2717 -2
Partials 343 343
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of minor comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will rely on Prince review for unit tests
fd92f24
to
111dc2a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few nits.
LGTM, assuming we are adding unit tests for newly added method as separate PR.
Description
Add parallel downloads job
Note: I will add more unit/composite tests in the next PR. Also, I will enable the configs to run e2e tests with parallel downloads in a separate PR.
Link to the issue in case of a bug fix.
NA
Testing details