Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making compute crc method context cancellable #2013

Merged
merged 7 commits into from
Jun 17, 2024
Merged

Conversation

vadlakondaswetha
Copy link
Collaborator

Description

Making compute crc method context cancellable, so it can be cancelled as part of job cancellation

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - Done
  2. Unit tests - Added
  3. Integration tests - NA

@vadlakondaswetha vadlakondaswetha requested a review from a team as a code owner June 13, 2024 10:58
@vadlakondaswetha vadlakondaswetha added the execute-integration-tests Run only integration tests label Jun 13, 2024
@vadlakondaswetha vadlakondaswetha changed the title Making compute crc method context cancellable [Do not review]Making compute crc method context cancellable Jun 13, 2024
Copy link

codecov bot commented Jun 13, 2024

Codecov Report

Attention: Patch coverage is 85.18519% with 4 lines in your changes missing coverage. Please review.

Project coverage is 71.55%. Comparing base (fd0ffb3) to head (40bbed5).
Report is 3 commits behind head on master.

Files Patch % Lines
internal/cache/file/downloader/job.go 85.71% 2 Missing ⚠️
internal/cache/util/util.go 84.61% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2013      +/-   ##
==========================================
- Coverage   71.86%   71.55%   -0.32%     
==========================================
  Files          97       97              
  Lines       10636    10872     +236     
==========================================
+ Hits         7644     7779     +135     
- Misses       2654     2745      +91     
- Partials      338      348      +10     
Flag Coverage Δ
unittests 71.55% <85.18%> (-0.32%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vadlakondaswetha vadlakondaswetha changed the title [Do not review]Making compute crc method context cancellable Making compute crc method context cancellable Jun 13, 2024
@vadlakondaswetha vadlakondaswetha merged commit b6eca68 into master Jun 17, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
execute-integration-tests Run only integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants