Add more tests (unit, composite) tests for parallel downloads #2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2019 +/- ##
==========================================
- Coverage 72.00% 71.98% -0.02%
==========================================
Files 99 99
Lines 10869 10869
==========================================
- Hits 7826 7824 -2
- Misses 2711 2713 +2
Partials 332 332
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sethiay
force-pushed
the
parallel_downloads_tests
branch
3 times, most recently
from
0bcf0a9
to
4be768a
Compare
sethiay
force-pushed
the
parallel_downloads_tests
branch
from
89b56e5
to
1c9b220
Compare
sethiay
added
the
parallel-downloads
ashmeenkaur
reviewed
Jun 20, 2024
tools/integration_tests/read_cache/cache_file_for_range_read_false_test.go
Outdated
Show resolved
Hide resolved
sethiay
force-pushed
the
parallel_downloads_tests
branch
from
34f5cb9
to
43f6e7f
Compare
raj-prince
reviewed
Jun 24, 2024
sethiay
force-pushed
the
parallel_downloads_tests
branch
from
143700a
to
f2f847e
Compare
sethiay
changed the title
raj-prince
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add some tests (unit, composite & e2e) tests for parallel downloads
I tried to add to existing e2e tests but those were failing, so we will address e2e tests in a separate PR.
Link to the issue in case of a bug fix.
NA
Testing details