Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix e2e test for hns bucket #2020

Merged
merged 2 commits into from
Jun 17, 2024
Merged

fix e2e test for hns bucket #2020

merged 2 commits into from
Jun 17, 2024

Conversation

Tulsishah
Copy link
Collaborator

@Tulsishah Tulsishah commented Jun 14, 2024

Description

  1. Increase the timeout for the storage client, as operations tests often run for more than 15 minutes.
  2. The HNS function process was running in the foreground, so we were unable to obtain a process ID and therefore couldn't get the correct exit code.

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - NA
  2. Unit tests - NA
  3. Integration tests - Automated

@Tulsishah Tulsishah added the execute-integration-tests Run only integration tests label Jun 14, 2024
Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.59%. Comparing base (70b6407) to head (8627c6a).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2020      +/-   ##
==========================================
+ Coverage   71.56%   71.59%   +0.02%     
==========================================
  Files          97       97              
  Lines       10705    10705              
==========================================
+ Hits         7661     7664       +3     
+ Misses       2703     2700       -3     
  Partials      341      341              
Flag Coverage Δ
unittests 71.59% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tulsishah Tulsishah marked this pull request as ready for review June 15, 2024 08:15
@Tulsishah Tulsishah requested a review from a team as a code owner June 15, 2024 08:15
@Tulsishah Tulsishah merged commit 6617ce1 into master Jun 17, 2024
12 checks passed
@Tulsishah Tulsishah deleted the fix_exit_code_for_hns branch July 19, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
execute-integration-tests Run only integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants