Convert Golang compliant flags to POSIX compliant #2030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Golang flags don't distinguish between single-hyphen and double-hyphen flags. POSIX compliant flags that are supported by pflag and Cobra however require flags to be prefixed with double hyphens. So, augment the flags in os.Args by converting the single-hyphen flags to double-hyphen ones.
kislaykishore
force-pushed
the
args-compat
branch
from
1ea634e
to
cd63292
Compare
-v has special meaning for Cobra which it uses to print version. Don't convert it to --v
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2030 +/- ##
==========================================
+ Coverage 71.40% 71.78% +0.37%
==========================================
Files 97 98 +1
Lines 10708 10851 +143
==========================================
+ Hits 7646 7789 +143
+ Misses 2719 2718 -1
- Partials 343 344 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ashmeenkaur
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Golang flags don't distinguish between single-hyphen and double-hyphen flags. POSIX compliant flags that are supported by pflag and Cobra however require flags to be prefixed with double hyphens. So, augment the flags in os.Args by converting the single-hyphen flags to double-hyphen ones so that they can be consumed by Cobra and Viper.
Description
Link to the issue in case of a bug fix.
NA
Testing details