Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore interrupts by default #2034

Merged
merged 6 commits into from
Jun 21, 2024
Merged

Conversation

ashmeenkaur
Copy link
Collaborator

Description

Change default value of ignore -interrupts flag to true.

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - Manually verified that the flag is true by default.
  2. Unit tests - NA
  3. Integration tests - updated

@ashmeenkaur ashmeenkaur added the execute-integration-tests Run only integration tests label Jun 19, 2024
Copy link

codecov bot commented Jun 19, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.01%. Comparing base (5eaf517) to head (b08f63f).
Report is 2 commits behind head on master.

Files Patch % Lines
cfg/config.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2034      +/-   ##
==========================================
+ Coverage   71.55%   72.01%   +0.46%     
==========================================
  Files          98       98              
  Lines       10756    10777      +21     
==========================================
+ Hits         7696     7761      +65     
+ Misses       2716     2687      -29     
+ Partials      344      329      -15     
Flag Coverage Δ
unittests 72.01% <75.00%> (+0.46%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ashmeenkaur ashmeenkaur marked this pull request as ready for review June 20, 2024 04:35
@ashmeenkaur ashmeenkaur requested a review from a team as a code owner June 20, 2024 04:35
@ashmeenkaur ashmeenkaur requested a review from sethiay June 20, 2024 04:35
raj-prince
raj-prince previously approved these changes Jun 20, 2024
Copy link
Collaborator

@raj-prince raj-prince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one minor comment.

@ashmeenkaur ashmeenkaur merged commit fefd11a into master Jun 21, 2024
13 checks passed
@ashmeenkaur ashmeenkaur deleted the ignore-interrupts-by-default branch June 21, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
execute-integration-tests Run only integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants