Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kernel List Cache: Composite Test #2036

Merged
merged 10 commits into from
Jul 3, 2024
Merged

Kernel List Cache: Composite Test #2036

merged 10 commits into from
Jul 3, 2024

Conversation

raj-prince
Copy link
Collaborator

@raj-prince raj-prince commented Jun 19, 2024

Description

  • Added basic composite test to make sure kernel-list-cache is working fine.
  • I'll add more tests in another PR - like creation or deletion of file inside a directory invalidates the cache.

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - NA
  2. Unit tests - NA
  3. Integration tests - NA

Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.66%. Comparing base (71e8a34) to head (72af7a3).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2036      +/-   ##
==========================================
+ Coverage   72.21%   72.66%   +0.45%     
==========================================
  Files         101      101              
  Lines       10956    11532     +576     
==========================================
+ Hits         7912     8380     +468     
- Misses       2714     2796      +82     
- Partials      330      356      +26     
Flag Coverage Δ
unittests 72.66% <ø> (+0.45%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@raj-prince raj-prince marked this pull request as ready for review June 26, 2024 06:24
@raj-prince raj-prince requested a review from a team as a code owner June 26, 2024 06:24
internal/fs/kernel_list_cache_test.go Outdated Show resolved Hide resolved
internal/fs/kernel_list_cache_test.go Show resolved Hide resolved
internal/fs/kernel_list_cache_test.go Show resolved Hide resolved
internal/fs/kernel_list_cache_test.go Outdated Show resolved Hide resolved
internal/fs/kernel_list_cache_test.go Outdated Show resolved Hide resolved
internal/fs/kernel_list_cache_test.go Show resolved Hide resolved
Tulsishah
Tulsishah previously approved these changes Jul 3, 2024
ashmeenkaur
ashmeenkaur previously approved these changes Jul 3, 2024
@raj-prince raj-prince dismissed stale reviews from ashmeenkaur and Tulsishah via 72af7a3 July 3, 2024 14:41
@raj-prince raj-prince merged commit 834238a into master Jul 3, 2024
13 checks passed
gargnitingoogle pushed a commit that referenced this pull request Jul 11, 2024
* Added simple cache hit/miss test

* Added cache related test, remaining: refactoring and with different operation

* pushing the internal changes

* Refactoring for basic test

* Fixing lint issue

* some cleaning

* review comments

* pushing missed file

* Rebase

* review comments
ashmeenkaur pushed a commit that referenced this pull request Jul 16, 2024
* Added simple cache hit/miss test

* Added cache related test, remaining: refactoring and with different operation

* pushing the internal changes

* Refactoring for basic test

* Fixing lint issue

* some cleaning

* review comments

* pushing missed file

* Rebase

* review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants