-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds get folder method in bucket.go #2041
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2041 +/- ##
==========================================
+ Coverage 71.55% 72.28% +0.73%
==========================================
Files 98 99 +1
Lines 10756 11038 +282
==========================================
+ Hits 7696 7979 +283
- Misses 2716 2730 +14
+ Partials 344 329 -15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should not put internal ticket id externally.
PTAL on that also.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from my side except few minor changes.
Description
integrates with get folder method of control client for all buckets (except fast stat bucket - next PR).
it is not called from anywhere, hence no change in existing functionality.
Link to the issue in case of a bug fix.
NA
Testing details