Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds get folder method in bucket.go #2041

Merged
merged 8 commits into from
Jun 24, 2024
Merged

adds get folder method in bucket.go #2041

merged 8 commits into from
Jun 24, 2024

Conversation

ankitaluthra1
Copy link
Collaborator

@ankitaluthra1 ankitaluthra1 commented Jun 20, 2024

Description

integrates with get folder method of control client for all buckets (except fast stat bucket - next PR).
it is not called from anywhere, hence no change in existing functionality.

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - Done
  2. Unit tests - Done
  3. Integration tests - NA

@ankitaluthra1 ankitaluthra1 added the execute-integration-tests Run only integration tests label Jun 20, 2024
@ankitaluthra1 ankitaluthra1 requested a review from a team as a code owner June 20, 2024 15:38
Copy link

codecov bot commented Jun 20, 2024

Codecov Report

Attention: Patch coverage is 28.57143% with 40 lines in your changes missing coverage. Please review.

Project coverage is 72.28%. Comparing base (5eaf517) to head (52af2bd).
Report is 5 commits behind head on master.

Files Patch % Lines
internal/storage/mock_bucket.go 0.00% 15 Missing ⚠️
internal/ratelimit/throttled_bucket.go 0.00% 6 Missing ⚠️
internal/monitor/bucket.go 0.00% 5 Missing ⚠️
internal/storage/caching/fast_stat_bucket.go 0.00% 5 Missing ⚠️
internal/storage/debug_bucket.go 0.00% 5 Missing ⚠️
internal/storage/fake/bucket.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2041      +/-   ##
==========================================
+ Coverage   71.55%   72.28%   +0.73%     
==========================================
  Files          98       99       +1     
  Lines       10756    11038     +282     
==========================================
+ Hits         7696     7979     +283     
- Misses       2716     2730      +14     
+ Partials      344      329      -15     
Flag Coverage Δ
unittests 72.28% <28.57%> (+0.73%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

internal/storage/bucket_handle_test.go Outdated Show resolved Hide resolved
internal/storage/mock_bucket.go Outdated Show resolved Hide resolved
internal/storage/mock_bucket.go Outdated Show resolved Hide resolved
internal/storage/mock_bucket.go Outdated Show resolved Hide resolved
internal/storage/mock_control_client.go Show resolved Hide resolved
Copy link
Collaborator

@Tulsishah Tulsishah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not put internal ticket id externally.
PTAL on that also.

Copy link
Collaborator

@Tulsishah Tulsishah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from my side except few minor changes.

internal/gcsx/prefix_bucket_test.go Outdated Show resolved Hide resolved
internal/storage/bucket_handle.go Show resolved Hide resolved
internal/storage/mock_control_client.go Show resolved Hide resolved
@ankitaluthra1 ankitaluthra1 merged commit bd88c1f into master Jun 24, 2024
13 checks passed
@ankitaluthra1 ankitaluthra1 deleted the b_341645964 branch July 29, 2024 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
execute-integration-tests Run only integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants