Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Config-CLI Parity][Fix] Populate config object when config file is not provided #2042

Merged
merged 3 commits into from
Jun 24, 2024

Conversation

ashmeenkaur
Copy link
Collaborator

@ashmeenkaur ashmeenkaur commented Jun 20, 2024

Description

Config object should be populated with only CLI flags in cases where config file is not provided.
Also resolves the config file path before usage.

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - Tested manually and printed the config object to confirm it is working as intended
  2. Unit tests - NA
  3. Integration tests - NA

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 71.48%. Comparing base (52b1e10) to head (2faa7ce).
Report is 344 commits behind head on master.

Files with missing lines Patch % Lines
cmd/root.go 20.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2042      +/-   ##
==========================================
+ Coverage   71.46%   71.48%   +0.01%     
==========================================
  Files          99       99              
  Lines       10800    10803       +3     
==========================================
+ Hits         7718     7722       +4     
+ Misses       2735     2734       -1     
  Partials      347      347              
Flag Coverage Δ
unittests 71.48% <20.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ashmeenkaur ashmeenkaur marked this pull request as ready for review June 21, 2024 04:57
@ashmeenkaur ashmeenkaur requested a review from a team as a code owner June 21, 2024 04:57
@ashmeenkaur ashmeenkaur requested a review from sethiay June 21, 2024 04:57
kislaykishore
kislaykishore previously approved these changes Jun 21, 2024
cmd/root.go Show resolved Hide resolved
@ashmeenkaur ashmeenkaur merged commit b6b4a80 into master Jun 24, 2024
13 checks passed
@ashmeenkaur ashmeenkaur deleted the populate_config_object_with_only_flags_too branch June 24, 2024 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants