Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use atleast 1 goroutine for async job #2056

Merged
merged 2 commits into from
Jun 24, 2024
Merged

Use atleast 1 goroutine for async job #2056

merged 2 commits into from
Jun 24, 2024

Conversation

sethiay
Copy link
Collaborator

@sethiay sethiay commented Jun 24, 2024

Description

Use atleast 1 goroutine for async job in parallel downloads.

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - NA
  2. Unit tests - NA
  3. Integration tests - NA

@sethiay sethiay added the execute-integration-tests Run only integration tests label Jun 24, 2024
@sethiay sethiay marked this pull request as ready for review June 24, 2024 11:17
@sethiay sethiay requested a review from a team as a code owner June 24, 2024 11:17
charith87
charith87 previously approved these changes Jun 24, 2024
Copy link

codecov bot commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.93%. Comparing base (32d784d) to head (acfa72d).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2056      +/-   ##
==========================================
+ Coverage   71.76%   71.93%   +0.17%     
==========================================
  Files          99       99              
  Lines       10862    10887      +25     
==========================================
+ Hits         7795     7832      +37     
+ Misses       2734     2722      -12     
  Partials      333      333              
Flag Coverage Δ
unittests 71.93% <100.00%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sethiay sethiay requested a review from charith87 June 24, 2024 11:41
@sethiay sethiay merged commit 60d5eb6 into master Jun 24, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
execute-integration-tests Run only integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants