[CLI Config Parity] migrate log-file legacy flag/config to new config #2062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashmeenkaur
changed the base branch from
master
to
create_new_config_from_legacy
ashmeenkaur
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## CLI_config_parity_release #2062 +/- ##
=============================================================
+ Coverage 72.14% 72.19% +0.04%
=============================================================
Files 100 100
Lines 10965 10957 -8
=============================================================
- Hits 7911 7910 -1
+ Misses 2719 2715 -4
+ Partials 335 332 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ashmeenkaur
force-pushed
the
create_new_config_from_legacy
branch
from
1007005
to
163957e
Compare
ashmeenkaur
force-pushed
the
Migrate_log_file
branch
from
afef9f0
to
e92fa74
Compare
ashmeenkaur
force-pushed
the
create_new_config_from_legacy
branch
from
163957e
to
9256265
Compare
ashmeenkaur
force-pushed
the
Migrate_log_file
branch
from
6d3b713
to
3ce34c3
Compare
Base automatically changed from
create_new_config_from_legacy
to
CLI_config_parity_release
June 26, 2024 11:39
ashmeenkaur
force-pushed
the
Migrate_log_file
branch
from
3ce34c3
to
f5f8ff9
Compare
ashmeenkaur
changed the title
kislaykishore
changed the title
kislaykishore
previously approved these changes
Jun 27, 2024
ashmeenkaur
force-pushed
the
Migrate_log_file
branch
from
1f5f49b
to
7816a90
Compare
kislaykishore
approved these changes
Jun 27, 2024
charith87
reviewed
Jun 27, 2024
charith87
approved these changes
Jun 28, 2024
kislaykishore
pushed a commit
that referenced
this pull request
Jun 28, 2024
…#2062) * removed log-file legacy usage * migrate log file flag * fix integration test * add unit test
ashmeenkaur
added
CLI Config Parity
and removed
execute-integration-tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is part of migration to new cobra/viper configs for CLI config parity.
Replaced usage of
log-fileflag stored inflagstorage.LogFileandmountConfig.LogConfig.FilePathtonewConfig.Logging.FilePath.Note: Post merging this PR, log-file flag will start taking precedence when both flag and config is set.
Link to the issue in case of a bug fix.
NA
Testing details