Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename parallel downloads flags #2064

Merged
merged 5 commits into from
Jun 25, 2024
Merged

Rename parallel downloads flags #2064

merged 5 commits into from
Jun 25, 2024

Conversation

sethiay
Copy link
Collaborator

@sethiay sethiay commented Jun 25, 2024 •
edited
Loading

Description

Rename parallel downloads flags to:

enable-parallel-downloads
parallel-downloads-per-file
max-parallel-downloads
download-chunk-size-mb
enable-crc

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - NA
  2. Unit tests - NA
  3. Integration tests - NA

@codecov Codecov
Copy link

codecov bot commented Jun 25, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 67.74194% with 10 lines in your changes missing coverage. Please review.

Project coverage is 72.02%. Comparing base (e247b84) to head (62438a3).
Report is 3 commits behind head on master.

Files Patch % Lines
cfg/config.go 0.00% 10 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2064      +/-   ##
==========================================
+ Coverage   71.98%   72.02%   +0.04%     
==========================================
  Files          99       99              
  Lines       10869    10879      +10     
==========================================
+ Hits         7824     7836      +12     
+ Misses       2713     2710       -3     
- Partials      332      333       +1
Flag Coverage Δ
unittests 72.02% <67.74%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sethiay sethiay marked this pull request as ready for review June 25, 2024 07:57
@sethiay sethiay requested review from kislaykishore and a team as code owners June 25, 2024 07:57
@sethiay sethiay added the execute-integration-tests Run only integration tests label Jun 25, 2024
@sethiay sethiay requested a review from ashmeenkaur June 25, 2024 10:44
ashmeenkaur
ashmeenkaur approved these changes Jun 25, 2024
View reviewed changes
Copy link
Collaborator

@ashmeenkaur ashmeenkaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relying on @kislaykishore's review

@sethiay sethiay merged commit 3f8314a into master Jun 25, 2024
13 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Jun 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashmeenkaur ashmeenkaur ashmeenkaur approved these changes

@kislaykishore kislaykishore kislaykishore approved these changes

@vadlakondaswetha vadlakondaswetha Awaiting requested review from vadlakondaswetha vadlakondaswetha is a code owner automatically assigned from GoogleCloudPlatform/gcsfuse-codeowners

Assignees
No one assigned
Labels
execute-integration-tests Run only integration tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sethiay @kislaykishore @ashmeenkaur