[CLI Config Parity] migrate key-file flag usage to new config #2069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## CLI_config_parity_release #2069 +/- ##
=============================================================
- Coverage 72.15% 72.13% -0.02%
=============================================================
Files 100 100
Lines 10965 10965
=============================================================
- Hits 7912 7910 -2
- Misses 2718 2720 +2
Partials 335 335
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Base automatically changed from
create_new_config_from_legacy
to
CLI_config_parity_release
June 26, 2024 11:39
ashmeenkaur
force-pushed
the
migrate_key_file
branch
from
27a6ce0 to
45d9f24
Compare
ashmeenkaur
force-pushed
the
migrate_key_file
branch
from
45d9f24 to
048b2f2
Compare
ashmeenkaur
changed the title
kislaykishore
previously approved these changes
Jun 26, 2024
Co-authored-by: Kislay Kishore <kislayk@google.com>
Co-authored-by: Kislay Kishore <kislayk@google.com>
kislaykishore
approved these changes
Jun 27, 2024
kislaykishore
added a commit
that referenced
this pull request
Jun 28, 2024
* remove key file flag usage * typo fix * review comment Co-authored-by: Kislay Kishore <kislayk@google.com> * review comment Co-authored-by: Kislay Kishore <kislayk@google.com> * remove unexported method test --------- Co-authored-by: Kislay Kishore <kislayk@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is part of migration to new cobra/viper configs for CLI config parity.
Replaced usage of
key-fileflag stored inflagstorage.KeyFiletonewConfig.GcsAuth.KeyFile.Link to the issue in case of a bug fix.
NA
Testing details