Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge master into CLI_config_parity_release #2070

Merged
merged 3 commits into from
Jun 27, 2024

Conversation

kislaykishore
Copy link
Collaborator

Doing a daily merge to avoid having significant differences between master and the CLI_config_parity_release branch.

Description

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - NA
  2. Unit tests - NA
  3. Integration tests - NA

Shadow the tc variable so that different subtests refer to their corresponding tc.

It'd have been fine had the subtests ran sequentially but in a parallel run, different tests sharing the same tc variable can lead to race.
@kislaykishore kislaykishore requested a review from a team as a code owner June 27, 2024 01:12
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

* Use default value based on number of CPU cores

* renames
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.33%. Comparing base (3f8314a) to head (ef2179c).
Report is 2 commits behind head on CLI_config_parity_release.

Current head ef2179c differs from pull request most recent head b8aa8dc

Please upload reports for the commit b8aa8dc to get more accurate results.

Additional details and impacted files
@@                      Coverage Diff                      @@
##           CLI_config_parity_release    #2070      +/-   ##
=============================================================
+ Coverage                      71.99%   72.33%   +0.33%     
=============================================================
  Files                             99      100       +1     
  Lines                          10870    11028     +158     
=============================================================
+ Hits                            7826     7977     +151     
- Misses                          2712     2716       +4     
- Partials                         332      335       +3     
Flag Coverage Δ
unittests 72.33% <100.00%> (+0.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kislaykishore kislaykishore merged commit 2a6fb30 into CLI_config_parity_release Jun 27, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants