Fix DeadLock in Kernel List Cache Feature #2100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2100 +/- ##
==========================================
- Coverage 71.93% 70.42% -1.51%
==========================================
Files 101 101
Lines 10996 11937 +941
==========================================
+ Hits 7910 8407 +497
- Misses 2758 3194 +436
- Partials 328 336 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
raj-prince
changed the title
ashmeenkaur
reviewed
Jul 5, 2024
ashmeenkaur
reviewed
Jul 5, 2024
sethiay
approved these changes
Jul 9, 2024
charith87
reviewed
Jul 9, 2024
ashmeenkaur
approved these changes
Jul 9, 2024
vadlakondaswetha
approved these changes
Jul 9, 2024
gargnitingoogle
pushed a commit
that referenced
this pull request
Jul 11, 2024
* Able to reproduce the hang * Adding composite test for deadlock case * Fixing lint issue * reverting minor line deletion * go import * comment changes * Review comments * Liting fix * Added more concurrent test
ashmeenkaur
pushed a commit
that referenced
this pull request
Jul 16, 2024
* Able to reproduce the hang * Adding composite test for deadlock case * Fixing lint issue * reverting minor line deletion * go import * comment changes * Review comments * Liting fix * Added more concurrent test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When
It happens when two parallel calls OpenDir and LookUpInode comes for the same directory.
Why
When kernel-list-cache is enabled (means ttl > 0), we were not following Lock ordering for dirInode and fs. Ideally, we should acquire dirInode lock first, but it was opposite. Fixing the order solves the issue.
Link to the issue in case of a bug fix.
#2104
Testing details