Integrating max retry attempts with client and changing the default retry attempts to 0

[Tulsishah]

Description

• Integrating max-retry-attempts in storage client to stop infinite retries on retry able errors.
• Changing default value to 0 to be backward compatible. setting max retry attempts to 0 implies infinite retries.

Link to the issue in case of a bug fix.

#1476

Testing details

1. Manual -
   Tested flag with storage test bench server.
   1. Cmd line (max-retry-attempts = 2) and config file flag not set.
      two retries occurred.
   2. Cmd line (max-retry-attempts = 2 )and config file (max-retry-attempts = 5)
      two retries occurred.
   3. Cmd line (max-retry-attempts not set) and config file (max-retry-attempts = 5)
      five retries occurred.
   4. Cmd line (max-retry-attempts not set) and config file (max-retry-attempts not set) = default 0 which means infinite
      Infinite retries occurred.
2. Unit tests - NA
3. Integration tests - NA

[codecov]

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.00%. Comparing base (dd5bc06) to head (48cf255).
Report is 34 commits behind head on master.

Files	Patch %	Lines
cfg/config.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2131      +/-   ##
==========================================
+ Coverage   71.73%   72.00%   +0.26%     
==========================================
  Files         101      101              
  Lines       11117    11168      +51     
==========================================
+ Hits         7975     8041      +66     
+ Misses       2813     2797      -16     
- Partials      329      330       +1     

Flag	Coverage Δ
unittests	72.00% <85.71%> (+0.26%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[kislaykishore]

The title appears misleading; should it be something like: "Changing the default retry attempts to 0". Also, in description we can add that "setting max retry attempts to 0 implies infinite retries".

[Tulsishah]

The title appears misleading; should it be something like: "Changing the default retry attempts to 0". Also, in description we can add that "setting max retry attempts to 0 implies infinite retries".

Done