Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade gem lock dependency #2209

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Upgrade gem lock dependency #2209

merged 1 commit into from
Jul 24, 2024

Conversation

Tulsishah
Copy link
Collaborator

@Tulsishah Tulsishah commented Jul 23, 2024 •
edited
Loading

Description

Dependabot dependency
0cb462f

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - Package building successfully
  2. Unit tests - NA
  3. Integration tests - NA
  4. Perf tests - B8dees2utG5HZvL

@Tulsishah Tulsishah added execute-perf-test Execute performance test in PR execute-integration-tests Run only integration tests labels Jul 23, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.24%. Comparing base (9955260) to head (3097676).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #2209   +/-   ##
=======================================
  Coverage   71.24%   71.24%           
=======================================
  Files         103      103           
  Lines       11393    11393           
=======================================
  Hits         8117     8117           
+ Misses       2941     2940    -1     
- Partials      335      336    +1
Flag Coverage Δ
unittests 71.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tulsishah Tulsishah marked this pull request as ready for review July 24, 2024 04:39
@Tulsishah Tulsishah requested a review from a team as a code owner July 24, 2024 04:39
@kislaykishore kislaykishore requested review from a team and gargnitingoogle and removed request for a team July 24, 2024 04:39
ashmeenkaur
ashmeenkaur approved these changes Jul 24, 2024
View reviewed changes
Copy link
Collaborator

@ashmeenkaur ashmeenkaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only being used during package building so LGTM if package is building fine after the dependency upgrade

@Tulsishah Tulsishah merged commit 43282a9 into master Jul 24, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashmeenkaur ashmeenkaur ashmeenkaur approved these changes

@charith87 charith87 Awaiting requested review from charith87 charith87 is a code owner automatically assigned from GoogleCloudPlatform/gcsfuse-codeowners

@gargnitingoogle gargnitingoogle Awaiting requested review from gargnitingoogle gargnitingoogle was automatically assigned from GoogleCloudPlatform/gcsfuse-shadow-reviewers

Assignees
No one assigned
Labels
execute-integration-tests Run only integration tests execute-perf-test Execute performance test in PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tulsishah @ashmeenkaur