Made the parallel downloads go routines running without synchronization #2287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2287 +/- ##
==========================================
+ Coverage 71.23% 79.65% +8.42%
==========================================
Files 106 106
Lines 11555 11601 +46
==========================================
+ Hits 8231 9241 +1010
+ Misses 2969 1923 -1046
- Partials 355 437 +82
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kislaykishore
requested review from
a team and
kislaykishore
and removed request for
a team
vadlakondaswetha
changed the title
vadlakondaswetha
force-pushed
the
paralleldownloads
branch
from
772be33
to
5238338
Compare
# Conflicts: # internal/cache/file/downloader/parallel_downloads_job.go
# Conflicts: # internal/cache/file/downloader/jm_parallel_downloads_test.go
# Conflicts: # internal/cache/file/downloader/jm_parallel_downloads_test.go
vadlakondaswetha
force-pushed
the
paralleldownloads
branch
from
5238338
to
39f27aa
Compare
sethiay
reviewed
Aug 9, 2024
sethiay
reviewed
Aug 9, 2024
sethiay
previously approved these changes
Aug 12, 2024
sethiay
previously approved these changes
Aug 12, 2024
sethiay
previously approved these changes
Aug 12, 2024
kislaykishore
previously approved these changes
Aug 12, 2024
vadlakondaswetha
dismissed stale reviews from kislaykishore and sethiay
via
2e4d17d
kislaykishore
approved these changes
Aug 12, 2024
sethiay
approved these changes
Aug 12, 2024
Tulsishah
pushed a commit
that referenced
this pull request
Aug 13, 2024
…on (#2287) * made the parallel go routines running without synchronization # Conflicts: # internal/cache/file/downloader/parallel_downloads_job.go * added print statement * fixing tests # Conflicts: # internal/cache/file/downloader/jm_parallel_downloads_test.go * added changes to update the marker file * reverting the test change * fixing the test * Fixing the integration tests * Fixing the test * releasign the goroutine * fixing tests # Conflicts: # internal/cache/file/downloader/jm_parallel_downloads_test.go * Code review comments * comments fixed * Added unit tests for updateRangeMap method * code review comments * code review comments * changed to require * code review comments * adding comment for public struct
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Incase of parallel downloads, we trigger n number of goroutines each downloading xMB and then we wait for xnMB to be downloaded and then make the goroutines fetch another xnMB.
Instead of that, we are making each goroutine continuously download xMB and then next xMB instead of worrying about other goroutines. Which offset to fetch will be passed via channel,.
Link to the issue in case of a bug fix.
NA
Testing details