Collecting rename metrics for nested folders #2370
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Made changes to existing functions to collected and accumulate metrics for nested folders as well.Previously, we had code which collected metrics related to rename operation for single level folders i.e.
Thus, metrics reported for these folders were in the form of average/min/max etc. time taken for each folder level rename operation.
Since, hns atomic rename is especially crucial in nested folder rename scenario , hence we do perf tests on simple nested scenario i.e.
Here we report the time of rename operation for renaming top_level_folder to top_level_folder_renamed so that we can observe performance comparison in cases where implicit-dirs are involved.
Link to the issue in case of a bug fix.
NA
Testing details