Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collecting rename metrics for nested folders #2370

Merged
merged 18 commits into from
Sep 4, 2024
Merged

Conversation

anushka567
Copy link
Member

@anushka567 anushka567 commented Aug 20, 2024

Description

Made changes to existing functions to collected and accumulate metrics for nested folders as well.Previously, we had code which collected metrics related to rename operation for single level folders i.e.

folder/
            file1.txt
            file2.txt
            ...
            file100.txt

Thus, metrics reported for these folders were in the form of average/min/max etc. time taken for each folder level rename operation.

Since, hns atomic rename is especially crucial in nested folder rename scenario , hence we do perf tests on simple nested scenario i.e.

top_level_folder/
                            folder1/
                                        file1.txt
                                        file2.txt
                                        ...
                                        file100.txt
                            folder2/
                                        file1.txt
                                        file2.txt
                                        ...
                                        file100.txt

Here we report the time of rename operation for renaming top_level_folder to top_level_folder_renamed so that we can observe performance comparison in cases where implicit-dirs are involved.

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - Tested the script to check for correct metric aggregation and upload to gsheet
  2. Unit tests - Added nested folder scenario for all existing unit tests.Also, added unit test for the common functions related to gsheet upload.
  3. Integration tests - NA

Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.04%. Comparing base (6677f9c) to head (9ed0fcb).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2370      +/-   ##
==========================================
- Coverage   79.07%   79.04%   -0.03%     
==========================================
  Files         106      106              
  Lines       11578    11578              
==========================================
- Hits         9155     9152       -3     
- Misses       1956     1958       +2     
- Partials      467      468       +1     
Flag Coverage Δ
unittests 79.04% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anushka567 anushka567 force-pushed the hns-rename-benchmark-6 branch 5 times, most recently from 00484ae to cad6265 Compare August 22, 2024 07:24
@anushka567 anushka567 force-pushed the hns-rename-benchmark-6 branch 2 times, most recently from c117d32 to f486ed9 Compare August 23, 2024 05:10
@anushka567 anushka567 changed the base branch from hns-rename-benchmark-6 to master August 23, 2024 09:29
@anushka567 anushka567 marked this pull request as ready for review August 27, 2024 10:11
@anushka567 anushka567 requested review from Tulsishah and a team as code owners August 27, 2024 10:11
@kislaykishore kislaykishore requested a review from a team August 27, 2024 10:11
@anushka567 anushka567 merged commit 6bdb29d into master Sep 4, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants