Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow a way to disable the use of O_DIRECT in parallel downloads #2372

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

sethiay
Copy link
Collaborator

@sethiay sethiay commented Aug 20, 2024

Description

Allow a way to disable the use of O_DIRECT in parallel downloads

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - Tried the flag during perf testing.
  2. Unit tests - Added.
  3. Integration tests - TBA in existing e2e tests in a separate PR

@sethiay sethiay added the execute-integration-tests Run only integration tests label Aug 20, 2024
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 6 lines in your changes missing coverage. Please review.

Project coverage is 79.03%. Comparing base (4638976) to head (e1b6740).
Report is 106 commits behind head on master.

Files with missing lines Patch % Lines
cfg/config.go 20.00% 2 Missing and 2 partials ⚠️
...al/cache/file/downloader/parallel_downloads_job.go 71.42% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2372      +/-   ##
==========================================
+ Coverage   79.01%   79.03%   +0.01%     
==========================================
  Files         105      105              
  Lines       11575    11584       +9     
==========================================
+ Hits         9146     9155       +9     
+ Misses       1963     1962       -1     
- Partials      466      467       +1     
Flag Coverage Δ
unittests 79.03% <57.14%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sethiay sethiay requested a review from charith87 August 20, 2024 14:53
@sethiay sethiay marked this pull request as ready for review August 20, 2024 14:53
@sethiay sethiay requested a review from a team as a code owner August 20, 2024 14:53
@kislaykishore kislaykishore requested review from a team and kislaykishore and removed request for a team August 20, 2024 14:53
charith87
charith87 previously approved these changes Aug 21, 2024
@sethiay sethiay merged commit 25b717d into master Aug 23, 2024
12 checks passed
@sethiay sethiay added the parallel-downloads-fixes Label to represent PRs related to parallel downloads bottleneck fixes label Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
execute-integration-tests Run only integration tests parallel-downloads-fixes Label to represent PRs related to parallel downloads bottleneck fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants