Remove fs-error label #2382
Merged
Remove fs-error label #2382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fs-error has a high cardinality and will not be supported by GCM. So, either we can drop it in gcsfuse or gcs-fuse-csi-driver will have to make changes to drop the label. fs-error is likely not needed since we already are classifying the most frequent errors into a new label called fs-err-category and the other errors are being classified into appropriate buckets. Moreover, we'd continue to have logs if we need to get more details about an (infrequent) error. So, we can remove fs-error label.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2382 +/- ##
=======================================
Coverage 79.09% 79.09%
=======================================
Files 105 105
Lines 11574 11574
=======================================
Hits 9155 9155
Misses 1956 1956
Partials 463 463
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
charith87
reviewed
Aug 23, 2024
charith87
reviewed
Aug 23, 2024
sethiay
approved these changes
Aug 23, 2024
charith87
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fs-error has a high cardinality and will not be supported by GCM. So, either we can drop it in gcsfuse or gcs-fuse-csi-driver will have to make changes to drop the label. fs-error is likely not needed since we already are classifying the most frequent errors into a new label called fs-err-category and the other errors are being classified into appropriate buckets. Moreover, we'd continue to have logs if we need to get more details about an (infrequent) error. So, we can remove fs-error label.
Description
Link to the issue in case of a bug fix.
NA
Testing details