Added todo for hns perf test with client protocol set to grpc #2388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anushka567
requested review from
vadlakondaswetha
and removed request for
a team
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2388 +/- ##
==========================================
+ Coverage 79.01% 79.07% +0.06%
==========================================
Files 105 105
Lines 11575 11575
==========================================
+ Hits 9146 9153 +7
+ Misses 1963 1958 -5
+ Partials 466 464 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ankitaluthra1
previously approved these changes
Aug 23, 2024
anushka567
dismissed
ankitaluthra1’s stale review
The base branch was changed.
anushka567
force-pushed
the
hns-perf-test-grpc
branch
from
dd73e3c
to
385ec49
Compare
Tulsishah
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently performance tests are run for flat bucket and HNS bucket mounted with client protocol set to http1. We want to run these perf tests with client protocol set to grpc but as of now, gRPC protocol is not working with includefoldersAsprefixes value true which is the default behavior.So, added a TODO.
Link to the issue in case of a bug fix.
NA
Testing details