Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change category name to look more like codes #2390

Merged
merged 3 commits into from
Aug 26, 2024
Merged

Conversation

kislaykishore
Copy link
Collaborator

Currently, the category names are phrases/sentences. Keeping it as codes makes them more succinct and easily searchable.

Description

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - NA
  2. Unit tests - NA
  3. Integration tests - NA

Currently, the category names are phrases/sentences. Keeping it as
codes makes them more succinct and easily searchable.
@kislaykishore kislaykishore requested a review from a team as a code owner August 23, 2024 08:23
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 88.23529% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.03%. Comparing base (f235e75) to head (c129b9d).

Files Patch % Lines
internal/fs/wrappers/monitoring.go 88.23% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2390      +/-   ##
==========================================
- Coverage   79.07%   79.03%   -0.04%     
==========================================
  Files         105      105              
  Lines       11572    11572              
==========================================
- Hits         9150     9146       -4     
- Misses       1958     1961       +3     
- Partials      464      465       +1     
Flag Coverage Δ
unittests 79.03% <88.23%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

charith87
charith87 previously approved these changes Aug 23, 2024
Copy link
Collaborator

@charith87 charith87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving.

@hime
Copy link

hime commented Aug 23, 2024

/lgtm

@kislaykishore kislaykishore merged commit 697baff into master Aug 26, 2024
9 of 10 checks passed
@kislaykishore kislaykishore deleted the remove-fs-err branch August 26, 2024 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants