Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[unsupported-object-issue-fix part1] Prep for fix empty directory list issue #2561

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

gargnitingoogle
Copy link
Collaborator

@gargnitingoogle gargnitingoogle commented Oct 8, 2024

Description

This adds utility for ignoring GCS objects which aren't supported in GCSFuse mounts. These objects have // in their names or have names starting with /. These can't be represented in linux FS, hence need to be ignored in GCSFuse mount.

This is followed up in #1876 (implementation) and e2e tests (#2011) .

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - NA
  2. Unit tests - NA
  3. Integration tests - NA

@gargnitingoogle gargnitingoogle marked this pull request as ready for review October 8, 2024 19:54
@gargnitingoogle gargnitingoogle requested a review from a team as a code owner October 8, 2024 19:54
@kislaykishore kislaykishore requested review from a team, tritone and kislaykishore and removed request for a team and tritone October 8, 2024 19:55
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 92.30769% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.37%. Comparing base (3b6804a) to head (60257eb).
Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
internal/util/gcs_util.go 92.30% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2561      +/-   ##
==========================================
- Coverage   78.38%   78.37%   -0.02%     
==========================================
  Files         107      108       +1     
  Lines       11793    11819      +26     
==========================================
+ Hits         9244     9263      +19     
- Misses       2058     2068      +10     
+ Partials      491      488       -3     
Flag Coverage Δ
unittests 78.37% <92.30%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant