Add a loop to read 5 times from kernel cache and take minimum listing time #2574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kislaykishore
requested review from
a team,
kislaykishore and
BrennaEpp
and removed request for
a team and
kislaykishore
Tulsishah
reviewed
Oct 10, 2024
tools/integration_tests/list_large_dir/list_dir_with_twelve_thousand_files_test.go
Outdated
Show resolved
Hide resolved
Tulsishah
reviewed
Oct 10, 2024
tools/integration_tests/list_large_dir/list_dir_with_twelve_thousand_files_test.go
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2574 +/- ##
==========================================
- Coverage 78.26% 78.18% -0.09%
==========================================
Files 107 107
Lines 11802 11802
==========================================
- Hits 9237 9227 -10
- Misses 2073 2086 +13
+ Partials 492 489 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Tulsishah
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a loop to read 5 times from kernel cache and take minimum listing time in order to ensure that listing from GCS takes twice or more time than listing from kernel cache .
Link to the issue in case of a bug fix.
NA
Testing details