-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add negative cache entry after deleting object/folderCache entry update #2822
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2822 +/- ##
==========================================
- Coverage 76.12% 76.01% -0.11%
==========================================
Files 118 118
Lines 16224 16328 +104
==========================================
+ Hits 12350 12412 +62
- Misses 3354 3396 +42
Partials 520 520
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the integration test label to validate that all tests are functioning correctly. Also, please include a composite test for this scenario.
tools/integration_tests/kernel_list_cache/infinite_kernel_list_cache_test.go
Show resolved
Hide resolved
tools/integration_tests/kernel_list_cache/infinite_kernel_list_cache_test.go
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Added integration test label. I think that, not handling error properly is a wider issue and needs to be taken care of in a different PR which should include composite test. I will raise a separate bug for the same and keep the scope of this PR limited for now. |
Description
After deleting an object or folder populate negative cache immediately.
This will save call/s to a backend to verify existence of a said object/folder resulting in perf gains.
Added invalidate logic in case of error to better handle all scenarios in case delete[object/folder] fails.
Link to the issue in case of a bug fix.
NA
Testing details