Setting bwh to nil after all fileHandles are closed #2823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kislaykishore
requested review from
a team,
tritone,
gargnitingoogle,
ashmeenkaur and
BrennaEpp
and removed request for
ashmeenkaur,
a team,
tritone,
gargnitingoogle and
BrennaEpp
# Conflicts: # internal/fs/inode/file_test.go
vadlakondaswetha
force-pushed
the
outoforder
branch
from
a383a6e to
30e1844
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2823 +/- ##
==========================================
- Coverage 75.94% 75.88% -0.06%
==========================================
Files 118 118
Lines 16320 16409 +89
==========================================
+ Hits 12394 12452 +58
- Misses 3409 3431 +22
- Partials 517 526 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ashmeenkaur
reviewed
Dec 24, 2024
ashmeenkaur
approved these changes
Dec 24, 2024
ankitaluthra1
pushed a commit
that referenced
this pull request
Dec 24, 2024
* fixing conflicts * fixing nil assert # Conflicts: # internal/fs/inode/file_test.go * not nil fix * storing fileHandle open semantics * Added unit tests for fileInode * Registering and deregistering. * ADDED COMMENTS * fixing panic * fixing tests * PR comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Setting bwh to nil after all fileHandles are closed in case of error.
Follow up PR will be raised to clear the buffers
Link to the issue in case of a bug fix.
NA
Testing details