Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(tutorial_langgraph.ipynb): fix duplicate description in LangGraph tools section #1659

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

bwnyasse
Copy link
Contributor

  • Remove duplicate description "Create custom Python functions to act as tools your AI application can use"

  • Replace router description with more specific text about routing logic and tool selection

@bwnyasse bwnyasse requested a review from a team as a code owner January 26, 2025 13:23
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Contributor

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi team,

I'm currently reviewing this pull request and will have a full review in a few minutes. In the meantime, here's a quick summary for you and other reviewers to get up to speed:

This pull request, submitted by bwnyasse, aims to improve the tutorial_langgraph.ipynb notebook within the generative-ai repository. The primary goal is to fix a duplicate description in the LangGraph tools section.

Specifically, the changes include:

  • Removing Duplicate Description: The duplicate description, "Create custom Python functions to act as tools your AI application can use," has been removed from the section describing the router.
  • Improving Router Description: The description of the router has been updated to provide more specific information about its role in controlling conversation flow and tool selection. The updated description is now: "Set up routing logic to control conversation flow and tool selection."

The changes are localized to lines 107-113 of gemini/reasoning-engine/tutorial_langgraph.ipynb. The updated description provides a clearer and more accurate representation of the router's functionality.

Here's a little haiku to lighten the mood:

Code flows like a stream,
Fixes clear, a polished gem,
Docs now shine so bright.

Thanks,
Gemini

Copy link
Contributor

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request effectively addresses the duplicate description and provides a more specific description for the router. This enhances the clarity and user experience of the tutorial. The change is minor but valuable. Well done!

Copy link
Member

@koverholt koverholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for catching this and for the edits!

@koverholt koverholt merged commit 557cef8 into GoogleCloudPlatform:main Jan 27, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants