fix: modernize background app

GoogleCloudPlatform · Aug 26, 2024 · 3a9e42e · 3a9e42e
1 parent d9da8db
commit 3a9e42e
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 12 deletions.
diff --git a/background/app/app.yaml b/background/app/app.yaml
@@ -13,5 +13,5 @@
 # limitations under the License.
 
 # [START getting_started_background_config]
-runtime: python37
+runtime: python312
 # [END getting_started_background_config]
diff --git a/background/app/main.py b/background/app/main.py
@@ -64,12 +64,10 @@ def translate():
  to_language = request.form.get("lang", "")
 
  if source_string == "":
- error_message = "Empty value"
- return error_message, 400
+ return f"Invalid request, you must provide a value.", 400
 
  if to_language not in ACCEPTABLE_LANGUAGES:
- error_message = "Unsupported language: {}".format(to_language)
- return error_message, 400
+ return f"Unsupported language: {to_language}", 400
 
  message = {
  "Original": source_string,
@@ -78,11 +76,9 @@ def translate():
  "OriginalLanguage": "",
  }
 
- topic_name = "projects/{}/topics/{}".format(
- os.getenv("GOOGLE_CLOUD_PROJECT"), "translate"
- )
+ topic_name = f"projects/{os.getenv('GOOGLE_CLOUD_PROJECT')}/topics/translate"
  publisher.publish(
- topic=topic_name, data=json.dumps(message).encode("utf8")
+ topic=topic_name, data=json.dumps(message).encode("utf-8")
  )
  return redirect("/")
 

diff --git a/background/app/requirements.txt b/background/app/requirements.txt
@@ -1,3 +1,3 @@
-google-cloud-firestore==2.11.1
-google-cloud-pubsub==2.16.1
-flask==2.2.5
+google-cloud-firestore==2.18.0
+google-cloud-pubsub==2.23.0
+flask==3.0.3