Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "All Rights Reserved." #2964

Closed
wants to merge 3 commits into from
Closed

Add "All Rights Reserved." #2964

wants to merge 3 commits into from

Conversation

briandealwis
Copy link
Member

Fixes #2916 to add "All Rights Reserved." There are three commits:

  1. the first amends the templates
  2. the second fixes existing usages
  3. the third replaces all existing Google Inc. with the new text

We can back out (3) but since the language has changed, the change can be deemed to be significant, even if it's of questionable effect.

@elharo
Copy link
Contributor

elharo commented Mar 22, 2018

NVM. There's conflicting internal documentation about whether All Rights Reserved is required or not. I kicked this up the chain, and the official response is we shouldn't use "All Rights Reserved".

@codecov
Copy link

codecov bot commented Mar 22, 2018

Codecov Report

Merging #2964 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2964      +/-   ##
============================================
- Coverage      69.2%   69.18%   -0.02%     
- Complexity     2648     2653       +5     
============================================
  Files           356      356              
  Lines         12428    12453      +25     
  Branches       1474     1477       +3     
============================================
+ Hits           8601     8616      +15     
- Misses         3220     3232      +12     
+ Partials        607      605       -2
Impacted Files Coverage Δ Complexity Δ
...pengine/facets/StandardFacetUninstallDelegate.java 84.21% <ø> (ø) 2 <0> (ø) ⬇️
...clipse/appengine/deploy/AppEngineDeployOutput.java 90.9% <ø> (ø) 7 <0> (ø) ⬇️
...se/appengine/libraries/repository/MavenHelper.java 67.64% <ø> (ø) 5 <0> (ø) ⬇️
...ipse/appengine/libraries/model/CloudLibraries.java 78.48% <ø> (ø) 12 <0> (ø) ⬇️
...clipse/appengine/deploy/ui/GcpProjectQueryJob.java 85% <ø> (ø) 5 <0> (ø) ⬇️
...appengine/facets/StandardFacetInstallDelegate.java 60.78% <ø> (ø) 7 <0> (ø) ⬇️
...aunching/LocalAppEngineStandardLaunchShortcut.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...calAppEngineServerLaunchConfigurationDelegate.java 64.19% <ø> (ø) 38 <0> (ø) ⬇️
...se/appengine/deploy/ui/DeployPreferencesPanel.java 33.33% <ø> (ø) 1 <0> (ø) ⬇️
...se/appengine/localserver/ui/AppEngineTabGroup.java 84.21% <ø> (ø) 3 <0> (ø) ⬇️
... and 133 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86bd279...0d82f88. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Google LLC
3 participants